Fixes for paywall tester #1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| // | ||
| // Copyright RevenueCat Inc. All Rights Reserved. | ||
| // | ||
| // Licensed under the MIT License (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // https://opensource.org/licenses/MIT | ||
| // | ||
| // FlexHStack.swift | ||
| // | ||
| // Created by Josh Holtz on 11/1/24. | ||
|
|
||
| import SwiftUI | ||
|
|
||
| #if PAYWALL_COMPONENTS | ||
|
|
||
| enum JustifyContent { | ||
| case start, center, end, spaceBetween, spaceAround, spaceEvenly | ||
| } | ||
|
|
||
| @available(iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0, *) | ||
| struct FlexHStack: View { | ||
| let alignment: VerticalAlignment | ||
| let justifyContent: JustifyContent | ||
| let spacing: CGFloat? | ||
| let componentViewModels: [PaywallComponentViewModel] | ||
|
|
||
| let onDismiss: () -> Void | ||
|
|
||
| init( | ||
| alignment: VerticalAlignment, | ||
| spacing: CGFloat?, | ||
| justifyContent: JustifyContent, | ||
| componentViewModels: [PaywallComponentViewModel], | ||
| onDismiss: @escaping () -> Void | ||
| ) { | ||
| self.alignment = alignment | ||
| self.spacing = spacing | ||
| self.justifyContent = justifyContent | ||
| self.componentViewModels = componentViewModels | ||
| self.onDismiss = onDismiss | ||
| } | ||
|
|
||
| var body: some View { | ||
| HStack(alignment: self.alignment, spacing: self.spacing) { | ||
| switch justifyContent { | ||
| case .start: | ||
| ForEach(0..<componentViewModels.count, id: \.self) { index in | ||
| ComponentsView(componentViewModels: [self.componentViewModels[index]], onDismiss: self.onDismiss) | ||
| } | ||
| Spacer() | ||
|
|
||
| case .center: | ||
| Spacer() | ||
| ForEach(0..<componentViewModels.count, id: \.self) { index in | ||
| ComponentsView(componentViewModels: [self.componentViewModels[index]], onDismiss: self.onDismiss) | ||
| } | ||
| Spacer() | ||
|
|
||
| case .end: | ||
| Spacer() | ||
| ForEach(0..<componentViewModels.count, id: \.self) { index in | ||
| ComponentsView(componentViewModels: [self.componentViewModels[index]], onDismiss: self.onDismiss) | ||
| } | ||
|
|
||
| case .spaceBetween: | ||
| ForEach(0..<componentViewModels.count, id: \.self) { index in | ||
| ComponentsView(componentViewModels: [self.componentViewModels[index]], onDismiss: self.onDismiss) | ||
| if index < self.componentViewModels.count - 1 { | ||
| Spacer() | ||
| } | ||
| } | ||
|
|
||
| case .spaceAround: | ||
| Spacer() | ||
| ForEach(0..<componentViewModels.count, id: \.self) { index in | ||
| ComponentsView(componentViewModels: [self.componentViewModels[index]], onDismiss: self.onDismiss) | ||
| if index < self.componentViewModels.count - 1 { | ||
| Spacer() | ||
| } | ||
| } | ||
| Spacer() | ||
|
|
||
| case .spaceEvenly: | ||
| ForEach(0..<componentViewModels.count, id: \.self) { index in | ||
| Spacer() | ||
| ComponentsView(componentViewModels: [self.componentViewModels[index]], onDismiss: self.onDismiss) | ||
| } | ||
| Spacer() | ||
|
Comment on lines
+86
to
+90
There was a problem hiding this comment. logic: spaceEvenly implementation places Spacer before first item, which differs from CSS flex justify-content: space-evenly. Should have equal space between all items |
||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #endif | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Using array index directly as id could cause issues if items change. Consider using a more stable identifier from PaywallComponentViewModel