rework eventbus scheduled rule execution #23

lizard-boy · 2024-09-20T12:34:19Z

Motivation

The key mechanism of the JobScheduler class was a 59.9 second wait event in a while true loop:

We have an event-based scheduler utility that could be used for the JobScheduler, which will also make things easier for our time simulation project.

So this PR is both about cleaning up tech debt and making the JobScheduler more flexible.

greptile-apps

This PR significantly refactors the EventBridge service in LocalStack, focusing on improving the job scheduling and event dispatching mechanisms.

Introduced a new Scheduler utility in utils/scheduler.py for more flexible and efficient task scheduling
Implemented CronScheduledTask and Job classes in events/scheduler.py to support both cron and rate expressions
Refactored EventsProvider in events/provider.py to use the new JobScheduler for handling scheduled rules
Added EventDispatcher and its implementations in events/dispatcher.py for improved event dispatching
Updated put_rule, delete_rule, disable_rule, and enable_rule methods to work with the new job scheduling system

_{5 file(s) reviewed, 2 comment(s)}
_{Edit PR Review Bot Settings}

greptile-apps · 2024-09-20T12:36:22Z

localstack/services/events/scheduler.py

+    if expression.startswith("rate"):
+        return parse_rate_expression(expression)
+
+    raise ValueError("Syntax error in expression")


style: Add more specific error message, e.g., 'Invalid schedule expression. Must start with "cron" or "rate".'

greptile-apps · 2024-09-20T12:37:24Z

localstack/utils/scheduler.py

+        if task.deadline is None:
+            task.deadline = max(task.start or 0, time.time())


style: Consider using 'or' instead of 'is None' for more concise code

rework eventbus scheduled rule execution

c62a127

greptile-apps bot reviewed Sep 20, 2024

View reviewed changes

		if task.deadline is None:
		task.deadline = max(task.start or 0, time.time())