[SFN] Handling of Unsupported ASL Bindings #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizard-boy
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added support for unknown bindings in the Step Functions ASL parser, allowing state machines with unsupported features to be created and executed while warning users of their presence.
- Introduced 'unknown_binding_decl' rule in ASLParser.g4 for top-level and state-level statements
- Added 'visitUnknown_binding_decl' method in preprocessor.py to log warnings for unknown bindings
- Created new test case 'test_unknown_bindings' in test_base.py to validate handling of unsupported features
- Updated test snapshots and validation files to include the new test case for unknown bindings
7 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+411
to
+412
| template["UnknownBinding"] = "StringValue" | ||
| template["States"]["State_1"]["UnknownBinding"] = {"KeyValue": [], "End": {}} |
There was a problem hiding this comment.
style: consider using a more descriptive key name than 'UnknownBinding' to clarify its purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the SFN v2 interpreter fails on parsing whenever a unknown production is added to the derivation. This leads to the user being unable to run the entire state machine if at least one derivation is unsupported. The most recent instance of is the use of Label fields (currently unsupported) in Map states localstack#11029, however this occurred in other instances such as Version, and Tolerance values. Although this project aims to support all ASL features, until a feature is supported, the user is unable to create the state machine, with the only solution being the manual removal of the unsupported production.
This PR wants to allow the user to create and execute the state machine regardless of unsupported language features, whilst being warned of the incident.
Changes
TODO
What's left to do: