feat: add StyleCop

gregarican · Sep 1, 2019 · 6f4c4e1 · 6f4c4e1
1 parent 1adabdb
commit 6f4c4e1
Show file tree

Hide file tree

Showing 139 changed files with 572 additions and 418 deletions.
diff --git a/pipedrive.ruleset b/pipedrive.ruleset
@@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="utf-8"?>
+<RuleSet Name="Pipedrive.net Rules" Description="Pipedrive.net Rules" ToolsVersion="15.0">
+  <Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
+    <Rule Id="SA0001" Action="None" />
+    <Rule Id="SA1009" Action="None" />
+	<Rule Id="SA1101" Action="None" />
+  	<Rule Id="SA1116" Action="None" />
+	<Rule Id="SA1117" Action="None" />
+	<Rule Id="SA1118" Action="None" />
+	<Rule Id="SA1128" Action="None" />
+	<Rule Id="SA1129" Action="None" />
+	<Rule Id="SA1201" Action="None" />
+	<Rule Id="SA1202" Action="None" />
+	<Rule Id="SA1204" Action="None" />
+	<Rule Id="SA1300" Action="None" />
+	<Rule Id="SA1303" Action="None" />
+	<Rule Id="SA1309" Action="None" />
+	<Rule Id="SA1311" Action="None" />
+	<Rule Id="SA1400" Action="None" />
+	<Rule Id="SA1401" Action="None" />
+	<Rule Id="SA1402" Action="None" />
+	<Rule Id="SA1404" Action="None" />
+	<Rule Id="SA1413" Action="None" />
+	<Rule Id="SA1501" Action="None" />
+	<Rule Id="SA1503" Action="None" />
+	<Rule Id="SA1600" Action="None" />
+	<Rule Id="SA1602" Action="None" />
+	<Rule Id="SA1615" Action="None" />
+	<Rule Id="SA1623" Action="None" />
+	<Rule Id="SA1629" Action="None" />
+    <Rule Id="SA1633" Action="None" />
+  </Rules>
+</RuleSet>
diff --git a/src/Pipedrive.net.Tests.Integration/Clients/ActivitiesClientTests.cs b/src/Pipedrive.net.Tests.Integration/Clients/ActivitiesClientTests.cs
@@ -127,7 +127,7 @@ public async Task CanDelete()
 
                 await fixture.Delete(createdActivity.Id);
 
-                var deletedActivity =  await fixture.Get(createdActivity.Id);
+                var deletedActivity = await fixture.Get(createdActivity.Id);
 
                 Assert.False(deletedActivity.ActiveFlag);
             }

diff --git a/src/Pipedrive.net.Tests.Integration/Clients/DealsClientTests.cs b/src/Pipedrive.net.Tests.Integration/Clients/DealsClientTests.cs
@@ -1,6 +1,6 @@
-using Pipedrive.CustomFields;
-using System;
+using System;
 using System.Threading.Tasks;
+using Pipedrive.CustomFields;
 using Xunit;
 
 namespace Pipedrive.Tests.Integration.Clients

diff --git a/src/Pipedrive.net.Tests.Integration/Helper.cs b/src/Pipedrive.net.Tests.Integration/Helper.cs
@@ -6,9 +6,15 @@ namespace Pipedrive.Tests.Integration
 {
     public static class Helper
     {
-        public static Uri ApiUrl { get { return _apiUrl.Value; } }
+        public static Uri ApiUrl
+        {
+            get { return _apiUrl.Value; }
+        }
 
-        public static string ApiToken { get { return Environment.GetEnvironmentVariable("PIPEDRIVE_APITOKEN"); } }
+        public static string ApiToken
+        {
+            get { return Environment.GetEnvironmentVariable("PIPEDRIVE_APITOKEN"); }
+        }
 
         static readonly Lazy<Uri> _apiUrl = new Lazy<Uri>(() =>
         {
@@ -39,6 +45,7 @@ public static Stream LoadFixture(string fileName)
                 throw new InvalidOperationException(
                     "The file '" + fileName + "' was not found as an embedded resource in the assembly. Failing the test...");
             }
+
             return stream;
         }
     }

diff --git a/src/Pipedrive.net.Tests.Integration/Helpers/IntegrationTestAttribute.cs b/src/Pipedrive.net.Tests.Integration/Helpers/IntegrationTestAttribute.cs
@@ -1,25 +1,8 @@
-using System.Collections.Generic;
-using Xunit;
-using Xunit.Abstractions;
+using Xunit;
 using Xunit.Sdk;
 
 namespace Pipedrive.Tests.Integration
 {
-    public class IntegrationTestDiscoverer : IXunitTestCaseDiscoverer
-    {
-        readonly IMessageSink diagnosticMessageSink;
-
-        public IntegrationTestDiscoverer(IMessageSink diagnosticMessageSink)
-        {
-            this.diagnosticMessageSink = diagnosticMessageSink;
-        }
-
-        public IEnumerable<IXunitTestCase> Discover(ITestFrameworkDiscoveryOptions discoveryOptions, ITestMethod testMethod, IAttributeInfo factAttribute)
-        {
-            return new[] { new XunitTestCase(diagnosticMessageSink, discoveryOptions.MethodDisplayOrDefault(), discoveryOptions.MethodDisplayOptionsOrDefault(), testMethod) };
-        }
-    }
-
     [XunitTestCaseDiscoverer("Pipedrive.Tests.Integration.IntegrationTestDiscoverer", "Pipedrive.Tests.Integration")]
     public class IntegrationTestAttribute : FactAttribute
     {

diff --git a/src/Pipedrive.net.Tests.Integration/Helpers/IntegrationTestDiscoverer.cs b/src/Pipedrive.net.Tests.Integration/Helpers/IntegrationTestDiscoverer.cs
@@ -0,0 +1,21 @@
+using System.Collections.Generic;
+using Xunit.Abstractions;
+using Xunit.Sdk;
+
+namespace Pipedrive.Tests.Integration
+{
+    public class IntegrationTestDiscoverer : IXunitTestCaseDiscoverer
+    {
+        readonly IMessageSink diagnosticMessageSink;
+
+        public IntegrationTestDiscoverer(IMessageSink diagnosticMessageSink)
+        {
+            this.diagnosticMessageSink = diagnosticMessageSink;
+        }
+
+        public IEnumerable<IXunitTestCase> Discover(ITestFrameworkDiscoveryOptions discoveryOptions, ITestMethod testMethod, IAttributeInfo factAttribute)
+        {
+            return new[] { new XunitTestCase(diagnosticMessageSink, discoveryOptions.MethodDisplayOrDefault(), discoveryOptions.MethodDisplayOptionsOrDefault(), testMethod) };
+        }
+    }
+}
diff --git a/src/Pipedrive.net.Tests.Integration/Pipedrive.Tests.Integration.csproj b/src/Pipedrive.net.Tests.Integration/Pipedrive.Tests.Integration.csproj
@@ -30,6 +30,10 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.2.0" />
+    <PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1">
       <PrivateAssets>all</PrivateAssets>
@@ -44,4 +48,11 @@
 
   <ProjectExtensions><VisualStudio><UserProperties /></VisualStudio></ProjectExtensions>
 
+  <PropertyGroup>
+    <CodeAnalysisRuleSet>..\..\pipedrive.ruleset</CodeAnalysisRuleSet>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <AdditionalFiles Include="..\..\stylecop.json" Link="stylecop.json" />
+  </ItemGroup>
 </Project>
diff --git a/src/Pipedrive.net.Tests/Clients/ActivitiesClientTests.cs b/src/Pipedrive.net.Tests/Clients/ActivitiesClientTests.cs
@@ -1,7 +1,7 @@
-using NSubstitute;
-using System;
+using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
+using NSubstitute;
 using Xunit;
 
 namespace Pipedrive.Tests.Clients
@@ -52,8 +52,7 @@ await connection.GetAll<Activity>(
                                 && d["done"] == "1"),
                         Arg.Is<ApiOptions>(o => o.PageSize == 1
                                 && o.PageCount == 1
-                                && o.StartPage == 0)
-                        );
+                                && o.StartPage == 0));
                 });
             }
         }
@@ -88,12 +87,11 @@ public async Task RequestsCorrectUrl()
                 {
                     await connection.GetAll<Activity>(
                         Arg.Is<Uri>(u => u.ToString() == "activities"),
-                        Arg.Is<Dictionary<string,string>>(d => d.Count == 1
+                        Arg.Is<Dictionary<string, string>>(d => d.Count == 1
                                 && d["done"] == "1"),
                         Arg.Is<ApiOptions>(o => o.PageSize == 1
                                 && o.PageCount == 1
-                                && o.StartPage == 0)
-                        );
+                                && o.StartPage == 0));
                 });
             }
         }
@@ -133,8 +131,7 @@ await connection.GetAll<Activity>(
                                 && d["done"] == "1"),
                         Arg.Is<ApiOptions>(o => o.PageSize == 1
                                 && o.PageCount == 1
-                                && o.StartPage == 0)
-                        );
+                                && o.StartPage == 0));
                 });
             }
         }

diff --git a/src/Pipedrive.net.Tests/Clients/ActivityFieldsClientTests.cs b/src/Pipedrive.net.Tests/Clients/ActivityFieldsClientTests.cs
@@ -1,6 +1,6 @@
-using NSubstitute;
-using System;
+using System;
 using System.Threading.Tasks;
+using NSubstitute;
 using Xunit;
 
 namespace Pipedrive.Tests.Clients

diff --git a/src/Pipedrive.net.Tests/Clients/ActivityTypesClientTests.cs b/src/Pipedrive.net.Tests/Clients/ActivityTypesClientTests.cs
@@ -1,6 +1,6 @@
-using NSubstitute;
-using System;
+using System;
 using System.Threading.Tasks;
+using NSubstitute;
 using Xunit;
 
 namespace Pipedrive.Tests.Clients

diff --git a/src/Pipedrive.net.Tests/Clients/CurrenciesClientTests.cs b/src/Pipedrive.net.Tests/Clients/CurrenciesClientTests.cs
@@ -1,7 +1,7 @@
-using NSubstitute;
-using System;
+using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
+using NSubstitute;
 using Xunit;
 
 namespace Pipedrive.Tests.Clients
@@ -27,7 +27,7 @@ public async Task RequestsCorrectUrl()
 
                 await client.GetAll();
 
-                Received.InOrder(async() =>
+                Received.InOrder(async () =>
                 {
                     await connection.GetAll<Currency>(Arg.Is<Uri>(u => u.ToString() == "currencies"));
                 });

diff --git a/src/Pipedrive.net.Tests/Clients/DealFieldsClientTests.cs b/src/Pipedrive.net.Tests/Clients/DealFieldsClientTests.cs
@@ -1,6 +1,6 @@
-using NSubstitute;
-using System;
+using System;
 using System.Threading.Tasks;
+using NSubstitute;
 using Xunit;
 
 namespace Pipedrive.Tests.Clients

diff --git a/src/Pipedrive.net.Tests/Clients/DealsClientTests.cs b/src/Pipedrive.net.Tests/Clients/DealsClientTests.cs
@@ -1,11 +1,10 @@
-using NSubstitute;
-using Pipedrive.CustomFields;
-using Pipedrive.Models.Response;
-using System;
+using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
+using NSubstitute;
+using Pipedrive.CustomFields;
+using Pipedrive.Models.Response;
 using Xunit;
-using static Pipedrive.DealsClient;
 
 namespace Pipedrive.Tests.Clients
 {
@@ -55,8 +54,7 @@ await connection.GetAll<Deal>(
                                 && d["status"] == "lost"),
                         Arg.Is<ApiOptions>(o => o.PageSize == 1
                                 && o.PageCount == 1
-                                && o.StartPage == 0)
-                        );
+                                && o.StartPage == 0));
                 });
             }
         }
@@ -96,8 +94,7 @@ await connection.GetAll<Deal>(
                                 && d["status"] == "lost"),
                         Arg.Is<ApiOptions>(o => o.PageSize == 1
                                 && o.PageCount == 1
-                                && o.StartPage == 0)
-                        );
+                                && o.StartPage == 0));
                 });
             }
         }
@@ -137,8 +134,7 @@ await connection.GetAll<Deal>(
                                 && d["status"] == "lost"),
                         Arg.Is<ApiOptions>(o => o.PageSize == 1
                                 && o.PageCount == 1
-                                && o.StartPage == 0)
-                        );
+                                && o.StartPage == 0));
                 });
             }
         }
@@ -277,8 +273,7 @@ await connection.GetAll<DealUpdateFlow>(
                             && d["id"] == "123"),
                         Arg.Is<ApiOptions>(o => o.PageSize == 1
                                 && o.PageCount == 1
-                                && o.StartPage == 0)
-                        );
+                                && o.StartPage == 0));
                 });
             }
         }
@@ -298,8 +293,7 @@ public async Task RequestsCorrectUrl()
                     await connection.GetAll<Follower>(
                         Arg.Is<Uri>(u => u.ToString() == "deals/123/followers"),
                         Arg.Is<Dictionary<string, string>>(d => d.Count == 1
-                            && d["id"] == "123")
-                        );
+                            && d["id"] == "123"));
                 });
             }
         }
@@ -369,8 +363,7 @@ await connection.GetAll<DealActivity>(
                             && d["done"] == "1"),
                         Arg.Is<ApiOptions>(o => o.PageSize == 1
                                 && o.PageCount == 1
-                                && o.StartPage == 0)
-                        );
+                                && o.StartPage == 0));
                 });
             }
         }
@@ -408,8 +401,7 @@ await connection.GetAll<DealParticipant>(
                             && d["id"] == "123"),
                         Arg.Is<ApiOptions>(o => o.PageSize == 1
                                 && o.PageCount == 1
-                                && o.StartPage == 0)
-                        );
+                                && o.StartPage == 0));
                 });
             }
         }

diff --git a/src/Pipedrive.net.Tests/Clients/FilesClientTests.cs b/src/Pipedrive.net.Tests/Clients/FilesClientTests.cs
@@ -1,7 +1,7 @@
-using NSubstitute;
-using System;
+using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
+using NSubstitute;
 using Xunit;
 
 namespace Pipedrive.Tests.Clients
@@ -49,8 +49,7 @@ await connection.GetAll<File>(
                         Arg.Is<Dictionary<string, string>>(d => d.Count == 0),
                         Arg.Is<ApiOptions>(o => o.PageSize == 1
                                 && o.PageCount == 1
-                                && o.StartPage == 0)
-                        );
+                                && o.StartPage == 0));
                 });
             }
         }

diff --git a/src/Pipedrive.net.Tests/Clients/NotesClientTests.cs b/src/Pipedrive.net.Tests/Clients/NotesClientTests.cs
@@ -1,7 +1,7 @@
-using NSubstitute;
-using System;
+using System;
 using System.Collections.Generic;
 using System.Threading.Tasks;
+using NSubstitute;
 using Xunit;
 
 namespace Pipedrive.Tests.Clients
@@ -49,8 +49,7 @@ await connection.GetAll<Note>(
                         Arg.Is<Dictionary<string, string>>(d => d.Count == 0),
                         Arg.Is<ApiOptions>(o => o.PageSize == 1
                                 && o.PageCount == 1
-                                && o.StartPage == 0)
-                        );
+                                && o.StartPage == 0));
                 });
             }
         }

diff --git a/src/Pipedrive.net.Tests/Clients/OrganizationFieldsClientTests.cs b/src/Pipedrive.net.Tests/Clients/OrganizationFieldsClientTests.cs
@@ -1,6 +1,6 @@
-using NSubstitute;
-using System;
+using System;
 using System.Threading.Tasks;
+using NSubstitute;
 using Xunit;
 
 namespace Pipedrive.Tests.Clients