Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Null Propagation Proposal #1694

Merged
merged 3 commits into from
Mar 19, 2025
Merged

Conversation

twof
Copy link
Contributor

@twof twof commented Mar 8, 2025

No description provided.

Comment on lines 176 to 183
While this proposal focuses on a simple boolean directive, future extensions might consider additional error behaviors:

- `PROPAGATE`: Current default behavior (errors propagate up)
- `NULL`: Replace errored positions with null
- `ABORT`: Abort the entire request on any error
- `INLINE`: Replace errored positions with an error representation

These additional behaviors are not part of this proposal but may be considered in future iterations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just punt this as it's already part of "alternatives considered" below

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving a quick link to the original proposal/spec edits for this, and removing INLINE as discussed there

@benjie benjie merged commit 7032c7f into graphql:main Mar 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants