Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove criteria F #1658

Closed
wants to merge 2 commits into from
Closed

Remove criteria F #1658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f807826
Remove criteria F
twof Feb 17, 2025
454c8d8
Merge branch 'main' into patch-31
benjie Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions rfcs/SemanticNullability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,19 +288,6 @@ or similar, and should carry the same meaning.

Criteria score: 🥇

## 🎯 F. Alternative syntaxes should not cause confusion

[criteria-f]: #-f-alternative-syntaxes-should-not-cause-confusion

Where a proposal allows alternative syntaxes to be used, the two syntaxes should
not cause confusion.

| [1][solution-1] | [2][solution-2] | [3][solution-3] | [4][solution-4] | [5][solution-5] | [6][solution-6] |
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
| ✅ | ✅ | ✅ | 🚫 | ✅ | ✅ |

Criteria score: 🥇

## 🎯 G. Error propagation boundaries should not change in existing executable documents

[criteria-g]: #-g-error-propagation-boundaries-should-not-change-in-existing-executable-documents
Expand Down Expand Up @@ -603,8 +590,6 @@ have been discussed the choice of symbol comes down mostly to aesthetics.
- 🚫 `Int*` syntax is not immediately obvious.
- [E][criteria-e]
- ✅ Same syntax.
- [F][criteria-f]
- ✅ Same syntax.
- [G][criteria-g]
- ✅ Error capture positions unchanged when error propagation enabled
- [H][criteria-h]
Expand Down Expand Up @@ -667,8 +652,6 @@ symbol) to indicate that a position may semantically be null.
obvious when `?` and `!` variants exist.
- [E][criteria-e]
- ✅ The same syntax is used on input and output.
- [F][criteria-f]
- ✅ There is no alternative syntax.
- [G][criteria-g]
- ✅ Error capture positions unchanged when error propagation enabled
- [H][criteria-h]
Expand Down Expand Up @@ -754,11 +737,6 @@ day-to-day work.
- ✅ Executable documents do not use `!!`, and `!` means non-nullable on both
input and output (the difference between semantic an strict non-null does
not occur on input)
- [F][criteria-f]
- ✅ `Int` reatains its meaning across both modes, and `Int!` means
non-nullable in both modes. Only the SDL ever uses `Int!!` and it still
means non-null, just with the additional "kills parent on exception"
behavior.
- [G][criteria-g]
- ✅ Error capture positions unchanged when error propagation enabled
- [H][criteria-h]
Expand Down Expand Up @@ -827,9 +805,6 @@ Syntax only changes when `@semanticNullability` directive is present:
- 🚫 If the schema uses `@semanticNullability` but an operation document does
not, `Int` has vastly different meanings: nullable on input but non-nullable
on output.
- [F][criteria-f]
- 🚫 `Int` being nullable in one mode and non-nullable in the other mode is
unexpected and will likely lead to confusion.
- [G][criteria-g]
- ✅ Error capture positions unchanged when error propagation enabled
- [H][criteria-h]
Expand Down Expand Up @@ -884,8 +859,6 @@ This proposal relies on the ability of clients to opt out of error propagation;
- ⚠️ Adding `@onError` to operations is not immediately intuitive but most error-handling clients should add it automatically, making it transparent to end users.
- [E][criteria-e]
- ✅ Same syntax.
- [F][criteria-f]
- ✅ Same syntax.
- [G][criteria-g]
- 🚫 Using non-null in more positions will change the error boundary positions when error propagation is enabled.
- [H][criteria-h]
Expand Down Expand Up @@ -954,8 +927,6 @@ positions.
- ✅ No syntax change (directive syntax already exists).
- [E][criteria-e]
- ✅ Same syntax.
- [F][criteria-f]
- ✅ Same syntax.
- [G][criteria-g]
- ✅ Error capture positions unchanged when error propagation enabled
- [H][criteria-h]
Expand Down