-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graphql-language-service): Support for experimental fragment arguments #3761
base: main
Are you sure you want to change the base?
Conversation
|
@@ -178,6 +178,9 @@ export function getTypeInfo( | |||
argDefs = | |||
directiveDef && (directiveDef.args as GraphQLArgument[]); | |||
break; | |||
case RuleKinds.FRAGMENT_SPREAD: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whether getting the type-info is actually needed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so you are lexing properly with the changes in Rules
, but you still need to track the arguments
here
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3761 +/- ##
==========================================
- Coverage 65.32% 65.31% -0.02%
==========================================
Files 122 122
Lines 7003 7006 +3
Branches 2260 2262 +2
==========================================
+ Hits 4575 4576 +1
- Misses 2411 2413 +2
Partials 17 17
|
label: 'someVariable', | ||
insertText: 'someVariable: ', | ||
command: suggestionCommand, | ||
insertTextFormat: 2, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this test is not working yet, even with your graphql-js changes, it may be because we aren't outputting the arguments in getTypeInfo
This is a work in progress branch for:
Being able to finish auto-complete and validation will depend on getting an alpha published as we need
parse
to behave well. The steps included in finishing this would be to add an auto-complete step for fragment arguments where we look up all fragments and check the available arguments so we can auto-complete.