Add support for onPrettifyQuery callback to enable customised query formatting #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0bc748a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
@i-like-robots can you sign CLA? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3640 +/- ##
==========================================
- Coverage 67.30% 67.28% -0.02%
==========================================
Files 121 121
Lines 7016 7018 +2
Branches 2263 2246 -17
==========================================
Hits 4722 4722
- Misses 2277 2279 +2
Partials 17 17
|
|
superseded by #3733 |
|
Thanks @dimaMachina 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new optional callback function named
onPrettifyQueryto enable the use of customised query formatting, such as integrating Prettier. This is a very quick POC implementation but I'm happy to invest more time if the feature is accepted as being valuable.When provided this callback will be invoked when the user formats the current contents of the query editor. It has no affect on the header or variable editors. The callback will receive the current value of the query editor and should return a string containing the formatted query. When the callback is not provided it will fallback to the current parse/print logic.
Intended to resolve #1517 and #3385.