Update annotation for client.execute_batch, get_execution_result argu… #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment. client.execute_batch was showing "No overload for provided arguments" in Pylance for vscode. Had to provide argument for get_execution_result to suppress error. Update overloads to have default values to overcome this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #483 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 2629 2629
=========================================
Hits 2629 2629 ☔ View full report in Codecov by Sentry. |
|
@rahul-gj Sorry for the delay. I modified the I don't use vscode or pylance so if you could verify that would be nice. Thanks for the report! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ment.
client.execute_batch was showing "No overload for provided arguments" in Pylance for vscode. Had to provide argument for get_execution_result to suppress error. Update overloads to have default values to overcome this.