Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GCS short live token #1140

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

rubenvp8510
Copy link
Collaborator

@rubenvp8510 rubenvp8510 commented Mar 26, 2025

Fixes #1141

@rubenvp8510 rubenvp8510 force-pushed the gcs_short_live_token branch 3 times, most recently from 21beb5e to 9cf95f2 Compare March 31, 2025 04:36
@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 83.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 58.85%. Comparing base (3b270ff) to head (89ec53a).

Files with missing lines Patch % Lines
internal/manifests/oauthproxy/oauth_proxy.go 0.00% 4 Missing and 1 partial ⚠️
internal/manifests/monolithic/serviceaccount.go 69.23% 3 Missing and 1 partial ⚠️
internal/manifests/manifestutils/storage.go 89.28% 2 Missing and 1 partial ⚠️
...nternal/manifests/serviceaccount/serviceaccount.go 0.00% 2 Missing and 1 partial ⚠️
internal/manifests/monolithic/statefulset.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1140      +/-   ##
==========================================
+ Coverage   58.57%   58.85%   +0.27%     
==========================================
  Files         113      113              
  Lines       10255    10319      +64     
==========================================
+ Hits         6007     6073      +66     
+ Misses       3939     3934       -5     
- Partials      309      312       +3     
Flag Coverage Δ
unittests 58.85% <83.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rubenvp8510 rubenvp8510 force-pushed the gcs_short_live_token branch 2 times, most recently from 86f6ced to f28b347 Compare March 31, 2025 05:20
@rubenvp8510 rubenvp8510 marked this pull request as ready for review March 31, 2025 05:20
@rubenvp8510 rubenvp8510 merged commit 4c7db5a into grafana:main Mar 31, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for GCP Workload Identity Federation short live token
3 participants