-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return the jsonpath of json detected fields #16861
Open
trevorwhitney
wants to merge
8
commits into
grafana:main
Choose a base branch
from
trevorwhitney:detected-fields-json-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: return the jsonpath of json detected fields #16861
trevorwhitney
wants to merge
8
commits into
grafana:main
from
trevorwhitney:detected-fields-json-path
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15ce780
to
9f86d57
Compare
trevorwhitney
commented
Mar 24, 2025
func (j *JSONParser) buildJSONPathFromPrefixBuffer() []string { | ||
jsonPath := make([]string, 0, len(j.prefixBuffer)) | ||
for _, part := range j.prefixBuffer { | ||
partStr := unsafe.String(unsafe.SliceData(part), len(part)) // #nosec G103 -- we know the string is not mutated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the parts of the path will not change, so I've optimized this to use unsafe.String
, which saves ~20% in terms of allocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR modifies the
/detected_fields
response to include the jsonpath of fields that were parsed from JSON objects. Since we use the_
character to represent both property nesting, as well as to escaped illegal characters from the label, there is no deterministic way to reverse engineer the jsonpath of the property from the label. Knowing the property is required to support a new JSON view for Logs Drilldown that will let users drilldown into certain JSON property, as we will be re-writing the query with arguments to the json parser to change the root key to the property the user has chosen to drill into, and we will need to know the correct path to that key.Benchmarks:
Which issue(s) this PR fixes:
Fixes #16816
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR