Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Meta Monitoring Loki v2 (Part 3) - documentation #16835

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

docs: Meta Monitoring Loki v2 (Part 3) - documentation #16835

wants to merge 10 commits into from
+247 −91

Conversation

Jayclifford345
Copy link
Contributor

@Jayclifford345 Jayclifford345 commented Mar 19, 2025 •
edited
Loading

What this PR does / why we need it:
This moves the meta-monitoring responsibilities from: https://github.com/grafana/meta-monitoring-chart
to the widely supported: https://github.com/grafana/k8s-monitoring-helm.

This is a 3-part PR:
Part 1: Add new values file for K8s-Monitoring-Helm to support Loki meta-monitoring #16665
Part 2: Update Loki Mixins to support changes #16962
Part 3: Update documentation

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Jayclifford345 Jayclifford345 requested a review from a team as a code owner March 19, 2025 17:29
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025 •
edited
Loading

💻 Deploy preview available:

JStickler
JStickler reviewed Mar 19, 2025
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Docs team]

@Jayclifford345 Jayclifford345 mentioned this pull request Mar 20, 2025
Open
6 tasks
JStickler
JStickler reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Docs team] Looking good. This is very close to ready to publish.

@Jayclifford345 Jayclifford345 mentioned this pull request Mar 31, 2025
Open
6 tasks
@Jayclifford345 @JStickler
Apply suggestions from code review
d05aa98 
Co-authored-by: J Stickler <[email protected]>
Signed-off-by: Jay Clifford <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JStickler JStickler JStickler left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jayclifford345 @JStickler