Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): ensure global.extraEnv and global.extraEnvFrom applied to all resources consistently #16828

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

siegenthalerroger
Copy link

What this PR does / why we need it:

The global.extraEnv and global.extraEnvFrom values introduced in chart 6.27.0 where not included for all declared resources and in some cases weren't applied correctly.

Similar PRs:

Which issue(s) this PR fixes:
Fixes #16380
Fixes #16565
Fixes #16683
Fixes #16713
Fixes #16713

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@siegenthalerroger siegenthalerroger requested a review from a team as a code owner March 19, 2025 10:23
@CLAassistant
Copy link

CLAassistant commented Mar 19, 2025

CLA assistant check
All committers have signed the CLA.

@reonokiy
Copy link

main...reonokiy:loki:main#diff-2cd62eebae

There are some other areas in the read module that need fixing (I'm mainly referencing the statefulset-read.yaml file). You can see the diff I posted above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants