feat(helm): Allow configurable severity and thresholds for alerts #13730
+79
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Loki helm chart comes with hardcoded
PrometheusRules
where users are unable to change the e.g., severity or threshold to best fit their environment's behavior.This PR allows users to set some overrides.
For example, in my environment, a
critical
severity may mean a phone call in the middle of the night. So I have a values.yaml with the following override:Which issue(s) this PR fixes:
Fixes #11219
Special notes for your reviewer:
values.yaml
monitoring.rules.disabled
keys (marking that as deprecated and to use configs for enabling/disabling). But we keep the deprecated keys for backwards compatibilityhelm template test --set loki.useTestSchema=true --set monitoring.rules.enabled=true --debug . --validate
and confirmed not rendered diff before and after.Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR