Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for k6 PR #4634, which adds Pushgateway support #1903

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marcoschulte
Copy link

What?

Hi everyone,

This PR adapts the remote write module documentation to describe the changes introduced through grafana/k6#4634

The last "limitation" I've added about using counters and gauges instead of native histograms, and the example about slow requests dominating fast ones, does actually also apply for the remote write case and not just for the Pushgateway. Therefore, it could be debated whether this should be moved up to "Counter and gauges" section.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/k6/next folder of the documentation.
  • I have reflected my changes in the docs/sources/k6/v{most_recent_release} folder of the documentation.
  • I have reflected my changes in the relevant folders of the two previous k6 versions of the documentation (if still applicable to previous versions).
  • I have made my changes in the docs/sources/k6/next folder of the documentation.

Related PR(s)/Issue(s)

grafana/k6#4634

…emote write module introduced through k6 PR #4634
@marcoschulte marcoschulte requested review from heitortsergent and a team as code owners March 18, 2025 15:38
@marcoschulte marcoschulte requested review from olegbespalov and joanlopez and removed request for a team March 18, 2025 15:38
@CLAassistant
Copy link

CLAassistant commented Mar 18, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants