-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing crypto
section since WebCrypto module has been promoted
#1886
base: main
Are you sure you want to change the base?
Conversation
Note that it's logically OK that new run-code-blocks fails on the k6 v0.56. |
Apply suggestions from code review Co-authored-by: Heitor Tashiro Sergent <[email protected]>
f575583
to
3ea0ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big one! Left just a couple of small comments, thanks for updating all these pages. 🙇
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
@heitortsergent the run examples workflow still failing (and will fail until we release the new version). Are we fine with merging this PR? |
@olegbespalov maybe we can wait until we're ready for the release next week to merge this PR? I know it's not ideal, I think we'll have to figure out a better way to handle the examples workflow for the next release. 😞 |
I don't see content added here mentioned in the release notes, so we can just wait the next week after the release, then merge when the new release has been published. I can take care of it. I open the new pull request for adding the new folder. @olegbespalov then we can rebase this pull request on top of it, WDYT? |
Thanks @codebien ! |
@olegbespalov here we are #1908 |
What?
This PR introduces a new
crypto
section of JavaScript API since thek6/experimental/webcrypto
has been promoted and now available globally (grafana/k6#4278). It also announces the deprecation of thek6/experimental/webcrypto
.Checklist
npm start
command locally and verified that the changes look good.docs/sources/k6/next
folder of the documentation.Related PR(s)/Issue(s)