Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing crypto section since WebCrypto module has been promoted #1886

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Mar 10, 2025

What?

This PR introduces a new crypto section of JavaScript API since the k6/experimental/webcrypto has been promoted and now available globally (grafana/k6#4278). It also announces the deprecation of the k6/experimental/webcrypto.

Checklist

  • I have used a meaningful title for the PR.
  • I have described the changes I've made in the "What?" section above.
  • I have performed a self-review of my changes.
  • I have run the npm start command locally and verified that the changes look good.
  • I have made my changes in the docs/sources/k6/next folder of the documentation.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov self-assigned this Mar 10, 2025
@olegbespalov olegbespalov requested review from heitortsergent and a team as code owners March 10, 2025 17:51
@olegbespalov olegbespalov requested review from codebien and joanlopez and removed request for a team March 10, 2025 17:52
@olegbespalov
Copy link
Contributor Author

Note that it's logically OK that new run-code-blocks fails on the k6 v0.56. crypto will be available only after v1.0.0-rc (which is not published)

olegbespalov and others added 2 commits March 17, 2025 15:03
Apply suggestions from code review

Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Copy link
Collaborator

@heitortsergent heitortsergent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big one! Left just a couple of small comments, thanks for updating all these pages. 🙇

Co-authored-by: Heitor Tashiro Sergent <[email protected]>
@olegbespalov
Copy link
Contributor Author

@heitortsergent the run examples workflow still failing (and will fail until we release the new version). Are we fine with merging this PR?

@heitortsergent
Copy link
Collaborator

@olegbespalov maybe we can wait until we're ready for the release next week to merge this PR? I know it's not ideal, I think we'll have to figure out a better way to handle the examples workflow for the next release. 😞

@codebien
Copy link
Contributor

I don't see content added here mentioned in the release notes, so we can just wait the next week after the release, then merge when the new release has been published. I can take care of it.

I open the new pull request for adding the new folder. @olegbespalov then we can rebase this pull request on top of it, WDYT?

@olegbespalov
Copy link
Contributor Author

Thanks @codebien !

@codebien
Copy link
Contributor

@olegbespalov here we are #1908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants