[synthetic-monitoring-agent] Update outdated chart & add extraEnv #3609
+19
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hnajib-sym
changed the title
|
@zanhsieh could you check this PR please |
|
@hnajib-sym |
|
I used more recent version of helm-docs, will install the required version and regenerate README @zanhsieh |
Signed-off-by: houcine.najib <[email protected]>
Signed-off-by: houcine.najib <[email protected]>
Signed-off-by: houcine.najib <[email protected]>
|
@zanhsieh can you relaunch CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set to latest release of synthetic-monitoring-agent is v0.34.4
Kubernetes requirement removed , doesn't make sense since chart is very basic.
UID in Dockerfile is set to 12345 hence
yaml runAsUser: 12345andyaml fsGroup: 12345Note
Pod fails with default UID 65534 , fsGroup updated to align
NET_RAWcapabilities is required else pod fails withoperation not permittedNote
synthetic-monitoring-agent Docker file is already add cap_net_raw
Warning
drop ALL take precedence and pod fails , so it was removed
yaml extraEnvwas added to able to pass GO PROXY environments variables : HTTP_PROXY & HTTPS_PROXY