[fluent-bit] fix(fluent-bit): servicemonitor label fix #3604
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
release
label fromServiceMonitor
Rationale
Prometheus operator is configured to scrape
ServiceMonitor
objects based on labels, and the common way to do this is by therelease
label of the Prometheus operator itself. Having a chart include its ownrelease
label in the object breaks this functionality without much added benefit.This is already the way e.g. Grafana Alloy chart is set up.
Current behaviour
Behaviour after this PR