[grafana] adds extraObjects as strings support #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallford
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor,
faustodavid,
a team,
jkroepke,
maorfr,
torstenwalter,
Xtigyro and
zanhsieh
as code owners
|
|
marshallford
force-pushed
the
extra-objects-string
branch
from
0f7297a to
cf8e18e
Compare
|
Hi, please create a distinct PR for each chart, thanks! |
jkroepke
reviewed
Mar 14, 2025
marshallford
changed the title
marshallford
force-pushed
the
extra-objects-string
branch
from
f34f272 to
158b663
Compare
… charts Signed-off-by: Marshall Ford <[email protected]>
Signed-off-by: Marshall Ford <[email protected]>
Signed-off-by: Marshall Ford <[email protected]>
marshallford
force-pushed
the
extra-objects-string
branch
from
158b663 to
c5836eb
Compare
jkroepke
approved these changes
Mar 14, 2025
|
Please also bump the chart version, thanks! |
Signed-off-by: Marshall Ford <[email protected]>
Done: #3603 |
jkroepke
changed the title
Signed-off-by: Marshall Ford <[email protected]>
Sheikh-Abubaker
approved these changes
Mar 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns with the behavior of the mimir-distributed Helm chart.