chore(GrafanaAlertRuleGroup): simplify finalize stage #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
Baarsgaard
force-pushed
the
fix_ignore_missing_alertrulegroups
branch
from
592d7f1 to
a4d3a9f
Compare
weisdd
requested changes
Mar 15, 2025
There was a problem hiding this comment.
@Baarsgaard I think it does make sense to remove rule group if CR is deleted, but there's something I'd like to clarify before doing anything about this PR. - You mentioned that the operator gets stuck when trying to finalize CR is the alert group is missing, but I couldn't reproduce that. Moreover, the part of the code that you changed explicitly handles 404 (not found) scenario. - What am I missing here?
Baarsgaard
force-pushed
the
fix_ignore_missing_alertrulegroups
branch
from
cbab794 to
2882642
Compare
Baarsgaard
force-pushed
the
fix_ignore_missing_alertrulegroups
branch
from
2882642 to
ab2b52b
Compare
|
Yeah, this was me late in the evening not doing my due diligence.. This does not fix a bug, it's a refactor to achieve the same with less requests. |
Baarsgaard
changed the title
GrafanaAlertRuleGroup on delete
weisdd
changed the title
weisdd
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of removing individual alerts, the operator removed the entire group like it does for folders (presence of individual dashboards is not checked there).