Cloudwatch: Update Namespace Metrics and Dimensions tests, add missing dimensions #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrhodes
commented
Mar 19, 2025
rrhodes
commented
Mar 19, 2025
|
Hi @rrhodes thanks for the contribution, these are great improvements. The lint step is failing, however, not sure if you can see the drone results, so pasting here: |
idastambuk
approved these changes
Mar 20, 2025
|
Hey @idastambuk, thanks for sharing the lint error, I'll patch that later today. |
|
@idastambuk 0c30c09 should address the lint errors. If all looks good, happy for this to be re-reviewed, and thanks for reviewing my other PR also! |
|
@rrhodes looks good, merging this. Thanks a lot! |
idastambuk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Test that maps for Namespace Metrics and Namespace Dimensions share the same key set. Tests identified two namespace keys missing from the Dimensions map which are added as part of this PR.
Closes #162