Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to confirm all CloudWatch Metrics have dimensions #162

Closed
iwysiu opened this issue Aug 8, 2024 · 1 comment · Fixed by #218
Closed

Add test to confirm all CloudWatch Metrics have dimensions #162

iwysiu opened this issue Aug 8, 2024 · 1 comment · Fixed by #218
Labels
datasource/CloudWatch good first issue Good for newcomers grafana-aws-sdk type/chore

Comments

@iwysiu
Copy link
Contributor

iwysiu commented Aug 8, 2024

We should add a test to pkg/cloudWatchConsts/metrics_test.go to confirm that NamespaceMetricsMap and NamespaceDimensionKeysMap in pkg/cloudWatchConsts/metrics.go have the same keys to make sure that new metrics have dimensions set.
@github-project-automation github-project-automation bot moved this to Incoming in AWS Datasources Aug 8, 2024
@rrhodes
Copy link
Contributor

rrhodes commented Mar 19, 2025

I'll have a PR raised to address this issue shortly.

@rrhodes rrhodes mentioned this issue Mar 19, 2025
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in AWS Datasources Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datasource/CloudWatch good first issue Good for newcomers grafana-aws-sdk type/chore
Projects
AWS Datasources
Status: Done
Milestone
No milestone
2 participants
@iwysiu @rrhodes