operator: Add initial concurrent reconciliation support #724
+862
−236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onprem
changed the title
onprem
force-pushed
the
prem/concurrent-reconcile
branch
from
40716b2 to
7c3618e
Compare
IfSentient
reviewed
Apr 10, 2025
onprem
force-pushed
the
prem/concurrent-reconcile
branch
2 times, most recently
from
b328b61 to
7cac3dd
Compare
I have added tests for |
Signed-off-by: Prem Saraswat <[email protected]>
Signed-off-by: Prem Saraswat <[email protected]>
Signed-off-by: Prem Saraswat <[email protected]>
Signed-off-by: Prem Saraswat <[email protected]>
onprem
force-pushed
the
prem/concurrent-reconcile
branch
2 times, most recently
from
7ac1804 to
7a30859
Compare
onprem
force-pushed
the
prem/concurrent-reconcile
branch
from
7a30859 to
66683eb
Compare
…rController Signed-off-by: Prem Saraswat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for reconciling events concurrently in
operator.InformerController. By default only1worker would be run, to maintain backward compatibility of processing the events sequentially.This is done with the help of a new
ResourceWatcherimplementation calledConcurrentWatcher, which runs multiple workers in the background and shards the incoming events between them. For every event, a hash mod is calculated on the identifier, allowing us to deliver events for same object to the same worker. This is done to maintain the per object in-order guarantee for events by Kubernetes.Why
This is needed for https://github.com/grafana/cloud-apps-platform/issues/883