deps: bump wasm-tracing to 1.0 #201
Conversation
WalkthroughThe pull request introduces updates to the Changes
Sequence DiagramsequenceDiagram
participant Client
participant LoggingModule
participant WasmTracing
Client->>LoggingModule: init_logging(config)
LoggingModule->>WasmTracing: Create WasmLayerConfig
WasmTracing-->>LoggingModule: Configure logging layer
LoggingModule-->>Client: Logging initialized
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
js/augurs-core-js/src/logging.rs (1)
114-114: Consider documenting the show_origin changeSince setting
show_origin: falseis a significant change introduced by wasm-tracing 1.0, consider adding a comment explaining this intentional change and its implications.+ // Explicitly disabled as per wasm-tracing 1.0 changes + // Origin details (line numbers, file names) are now omitted from logs show_origin: false,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
js/augurs-core-js/Cargo.toml(1 hunks)js/augurs-core-js/src/logging.rs(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- js/augurs-core-js/Cargo.toml
🔇 Additional comments (4)
js/augurs-core-js/src/logging.rs (4)
10-10: LGTM: Import statement correctly updated for wasm-tracing 1.0
The import statement has been properly updated to include the new types from wasm-tracing 1.0.
105-115: LGTM: Configuration setup properly implements wasm-tracing 1.0 changes
The WasmLayerConfig construction correctly maps all configuration parameters and aligns with the new API requirements.
116-116: LGTM: Logging initialization properly updated
The initialization code correctly uses the new WasmLayer configuration while maintaining proper error handling.
Line range hint 1-116: Verify wasm-tracing dependency version
Let's verify that the wasm-tracing dependency has been properly updated in Cargo.toml.
✅ Verification successful
Dependency version verified successfully
The wasm-tracing dependency is correctly specified with version "1.0.1" in the Cargo.toml file.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if wasm-tracing dependency is updated to 1.0
rg -U 'wasm-tracing.*=.*"1\.0' js/augurs-core-js/Cargo.toml
Length of output: 115
The 1.0 update improves the APIs and includes a helpful change to omit the origin (line number, file name) from the logs (dsgallups/wasm-tracing#11).
sd2k
force-pushed
the
bump-wasm-tracing
branch
from
b701102 to
dfce793
Compare
The 1.0 update improves the APIs and includes a helpful change to
omit the origin (line number, file name) from the logs
(dsgallups/wasm-tracing#11).
Summary by CodeRabbit
New Features
Bug Fixes
Chores
wasm-tracingto ensure compatibility and performance improvements.