-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for otel collector environment variables #3048
Merged
mattdurham
merged 6 commits into
main
from
2947-support-converting-env-variables-from-otel-config-file
Mar 26, 2025
Merged
feat: add support for otel collector environment variables #3048
mattdurham
merged 6 commits into
main
from
2947-support-converting-env-variables-from-otel-config-file
Mar 26, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💻 Deploy preview deleted. |
20a3f03
to
c14c25f
Compare
c14c25f
to
58cde49
Compare
Co-authored-by: Clayton Cornell <[email protected]>
Docs are OK. |
mattdurham
reviewed
Mar 24, 2025
internal/converter/internal/otelcolconvert/envprovider/env_provider.go
Outdated
Show resolved
Hide resolved
wildum
reviewed
Mar 25, 2025
internal/converter/internal/otelcolconvert/envprovider/env_provider.go
Outdated
Show resolved
Hide resolved
dehaansa
reviewed
Mar 25, 2025
internal/converter/internal/otelcolconvert/testdata/envvars/default_value_format.yaml
Outdated
Show resolved
Hide resolved
wildum
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
clayton-cornell
approved these changes
Mar 26, 2025
@mattdurham @wildum @dehaansa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds support for converting environment variables in OpenTelemetry Collector config files to equivalent Alloy config syntax.
This is accomplished by:
sys.env("NAME_OF_ENV_VAR")
, wrapped in acoalese
to properly handle default values, if present in the otelcol config.Which issue(s) this PR fixes
Closes #2947
Notes to the Reviewer
${FOO}
and$${FOO}
. The logic will convert both of these to thesys.env
format, even though this is not 100% congruent with how OpenTelemetry treats these values.PR Checklist