Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API error handling in JS Client #10890

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

l2dy
Copy link
Contributor

@l2dy l2dy commented Mar 26, 2025

Description

Fix a silent error in the catch clause, matching how errors are handled in

} catch (e) {
throw new Error(BROKEN_CONNECTION_MSG + (e as Error).message);
}

Closes: N/A (small fix)

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@l2dy l2dy marked this pull request as ready for review March 26, 2025 16:34
@hannahblair hannahblair self-requested a review March 27, 2025 17:16
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Mar 27, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/dc3668699550ec86a777199a42b663f2cb4c2651/gradio-5.23.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@dc3668699550ec86a777199a42b663f2cb4c2651#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/dc3668699550ec86a777199a42b663f2cb4c2651/gradio-client-1.14.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/dc3668699550ec86a777199a42b663f2cb4c2651/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/client minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Improve API error handling in JS Client

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Mar 31, 2025
@hannahblair
Copy link
Collaborator

hi @l2dy! Looks good! The tests are failing now because they're written to expect non-failure. Now that we're throwing an error, can you update it to expect that?

@hannahblair hannahblair requested a review from Copilot March 31, 2025 16:47
Copilot

This comment was marked as resolved.

@hannahblair
Copy link
Collaborator

@l2dy If you need some help, you can comment out the failing test and I can come back to it - there are some improvements to that test that should be made anyway 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants