-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve API error handling in JS Client #10890
base: main
Are you sure you want to change the base?
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/dc3668699550ec86a777199a42b663f2cb4c2651/gradio-5.23.1-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@dc3668699550ec86a777199a42b663f2cb4c2651#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/dc3668699550ec86a777199a42b663f2cb4c2651/gradio-client-1.14.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/dc3668699550ec86a777199a42b663f2cb4c2651/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
hi @l2dy! Looks good! The tests are failing now because they're written to expect non-failure. Now that we're throwing an error, can you update it to expect that? |
@l2dy If you need some help, you can comment out the failing test and I can come back to it - there are some improvements to that test that should be made anyway 🙂 |
Description
Fix a silent error in the catch clause, matching how errors are handled in
gradio/client/js/src/utils/upload_files.ts
Lines 39 to 41 in b6bcd04
Closes: N/A (small fix)
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh