Skip to content

feat(a11y): transfer accessible property to BottomSheet's children #2191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomas-cicognani-post
Copy link

Transfer accessible property to Bottom Sheet's children in order to improve keyboard navigation and VoiceOver / TalkBack results.

Motivation

When fixing some accessibility features like keyboard navigation in our application, I discovered that some parts of the Bottom Sheet are accessible when you use, for instance, the keyboard tabulation. The consequence is users can be lost because the selected element in UI is not visible nor pertinent. Same for blind or visual impaired people who use VoiceOver / TalkBack, the smartphone says thinks like "Bottom Sheet" or "Bottom Sheet Handle", which may be not pertinent to browse the app.

In that case, the main property "accessible" from the Bottom Sheet props may be transferred to its children if we need to enable or disable the accessibility. We only changed components we use and must be updated with the accessible property to fix our app.

Thus, in our app, we instantiate several Bottom Sheets, so we have to disable all hidden sheets and only enable the one which is opened. If we don't do that, keyboard tabulation goes through all Bottom Sheets even they are not visible.

Copy link

github-actions bot commented Apr 7, 2025

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant