chore: add jdk 23 job for showcase tests #3571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of introducing support for GraalVM for JDK 23
We remove showcase-native because it's already being [tested in Cloud Build](https://www.google.com/url?q=https://github.com/googleapis/sdk-platform-java/blob/09d9708dec7ef82f7d269c6285a9588dec48ac5d/.cloudbuild/graalvm/cloudbuild-test-a.yaml%23L45&sa=D&source=docs&ust=1737144190134588&usg=AOvVaw0VT7f-vqeGpoSEAKvWhwg9)
product-auto-label
bot
added
size: s
Aborting upgrade to jdk 23 as showcase covers it
whitespace
|
|
mpeddada1
approved these changes
Jan 17, 2025
lqiu96
reviewed
Jan 17, 2025
| @@ -214,7 +214,7 @@ jobs: | |||
| runs-on: ubuntu-22.04 | |||
| strategy: | |||
| matrix: | |||
| java: [ 11, 17, 21 ] | |||
| java: [ 11, 17, 21, 23 ] | |||
There was a problem hiding this comment.
Is the plan to just keep this as a matrix of Java LTS versions + latest Java release?
lqiu96
approved these changes
Jan 17, 2025
blakeli0
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also remove showcase-native because it's already being tested in Cloud Build