-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Update the gapic-generator and hermetic-build golden files' copyright to 2025 #3550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Min! Can you please make it clear that these golden files do not fail the unit tests? And they might get cleaned up in the future.
Updated description to provide more info. |
Hermetic library generation upon generation config change through pull requests / library_generation (pull_request) Failing after 31m
Based on description in script here:
I am not sure if this test should run on this pr? UPDATE: hint from above error, merge main into this resolved it. |
Quality Gate passed for 'gapic-generator-java-root'Issues Measures |
Quality Gate passed for 'java_showcase_integration_tests'Issues Measures |
follow-up to #3513,
Changes in this PR:
mvn test -DupdateUnitGoldens
from gapic-generator-java/. Note that unit tests without this change did not fail. Filed investigate if test golden files are orphaned #3556 to investigate and maybe remove these in the future.sdk-platform-java/hermetic_build/library_generation/owlbot/synthtool/languages/java.py
Lines 113 to 116 in 67f5ea2