Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Update OpenTelemetry semantic convention packages in the shared dependencies #3402

Merged
merged 6 commits into from
Feb 5, 2025
Merged

deps: Update OpenTelemetry semantic convention packages in the shared dependencies #3402

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea331d4
chore: Update OpenTelemetry semantic convention packages in the share…
michaelpri10 Nov 27, 2024
5bbeba5
chore: Remove non-GA opentelemetry-semconv-incubating dependency
michaelpri10 Jan 24, 2025
591bc58
Merge branch 'main' into main
michaelpri10 Jan 24, 2025
5d7e6fa
chore: Re-add old semconv package dependency since the Pub/Sub librar…
michaelpri10 Jan 24, 2025
0dd1501
Merge branch 'main' into main
michaelpri10 Jan 24, 2025
e7778aa
Merge branch 'main' into main
lqiu96 Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions java-shared-dependencies/third-party-dependencies/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@
<artifactId>opentelemetry-grpc-1.6</artifactId>
<version>${opentelemetry-grpc-instrumentation.version}</version>
</dependency>
<dependency>
<groupId>io.opentelemetry.semconv</groupId>
<artifactId>opentelemetry-semconv</artifactId>
<version>${opentelemetry-semconv.version}</version>
</dependency>
<dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the io.opentelemetry:opentelemetry-semconv deps below (L147-L150) be removed since it's now io.opentelemetry.semconv:opentelemetry-semconv?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had tried that originally, but saw some checks fail because the Pub/Sub library currently uses the old io.opentelemetry:opentelemetry-semconv dependency. I was planning to remove that old one in a follow-up PR after the dependency is removed in Pub/Sub.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense. I believe our downstream tests use the latest released version of pubsub. In that case, would you mind either creating an issue in this repo or adding a comment in the ticket so we don't forget to remove the old deps?

<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-semconv</artifactId>
Expand Down
Loading