Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery/admin/v2): generate library #1540

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Mar 19, 2025

Generate the "admin" library. This is basically the bigquery/v2 library with
some omissions.

I think we will want to include the Query() and GetQueryResults() RPCs in a
hand-crafted library, and probably using the BigQuery Storage APIs as the
underlying implementation. If I am wrong, we can always add these methods back.

Fixes #829

@coryan coryan changed the title Feat bigquery v2 generate library feat(bigquery/admin/v2): generate library Mar 19, 2025
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.19%. Comparing base (a9c0c0c) to head (c4d565e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1540   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files          39       39           
  Lines        1603     1603           
=======================================
  Hits         1526     1526           
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Generate the "admin" library. This is basically the bigquery/v2 library with
some omissions.

I think we will want to include the `Query()` and `GetQueryResults()` RPCs in a
hand-crafted library, and probably using the BigQuery Storage APIs as the
underlying implementation. If I am wrong, we can always add these methods back.
@coryan coryan force-pushed the feat-bigquery-v2-generate-library branch from 3e24807 to c4d565e Compare March 19, 2025 14:46
@coryan coryan marked this pull request as ready for review March 19, 2025 15:04
@coryan coryan requested review from dbolduc and codyoss March 19, 2025 15:04
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but check the not-for-publication = 'true' bit. Seems wrong to me, but maybe I don't know the plan.

@@ -69,6 +69,7 @@ members = [
"src/generated/cloud/beyondcorp/appgateways/v1",
"src/generated/cloud/beyondcorp/clientconnectorservices/v1",
"src/generated/cloud/beyondcorp/clientgateways/v1",
"src/generated/cloud/bigquery/admin/v2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am iffy, but ok with making up an admin directory when it doesn't exist...

I am guessing the eventual veneer will be google-cloud-bigquery and you are trying to avoid confusion between that and google-cloud-bigquery-v2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am iffy, but ok with making up an admin directory when it doesn't exist...

The directory does not matter. We can move packages around, remember? Only the package name matters. I picked the directory to match the package name.

I am guessing the eventual veneer will be google-cloud-bigquery and you are trying to avoid confusion between that and google-cloud-bigquery-v2

google-cloud-bigquery (in the src/bigquery directory) seems likely. I renamed the package because it is a selection from google-cloud-bigquery-v2, but now that you ask, I am not sure... Let me ponder this a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate library for google/cloud/bigquery/v2 (admin)
2 participants