-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigquery/admin/v2): generate library #1540
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1540 +/- ##
=======================================
Coverage 95.19% 95.19%
=======================================
Files 39 39
Lines 1603 1603
=======================================
Hits 1526 1526
Misses 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generate the "admin" library. This is basically the bigquery/v2 library with some omissions. I think we will want to include the `Query()` and `GetQueryResults()` RPCs in a hand-crafted library, and probably using the BigQuery Storage APIs as the underlying implementation. If I am wrong, we can always add these methods back.
3e24807
to
c4d565e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but check the not-for-publication = 'true'
bit. Seems wrong to me, but maybe I don't know the plan.
@@ -69,6 +69,7 @@ members = [ | |||
"src/generated/cloud/beyondcorp/appgateways/v1", | |||
"src/generated/cloud/beyondcorp/clientconnectorservices/v1", | |||
"src/generated/cloud/beyondcorp/clientgateways/v1", | |||
"src/generated/cloud/bigquery/admin/v2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am iffy, but ok with making up an admin
directory when it doesn't exist...
I am guessing the eventual veneer will be google-cloud-bigquery
and you are trying to avoid confusion between that and google-cloud-bigquery-v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am iffy, but ok with making up an
admin
directory when it doesn't exist...
The directory does not matter. We can move packages around, remember? Only the package name matters. I picked the directory to match the package name.
I am guessing the eventual veneer will be
google-cloud-bigquery
and you are trying to avoid confusion between that andgoogle-cloud-bigquery-v2
google-cloud-bigquery
(in the src/bigquery
directory) seems likely. I renamed the package because it is a selection from google-cloud-bigquery-v2
, but now that you ask, I am not sure... Let me ponder this a bit.
Generate the "admin" library. This is basically the bigquery/v2 library with
some omissions.
I think we will want to include the
Query()
andGetQueryResults()
RPCs in ahand-crafted library, and probably using the BigQuery Storage APIs as the
underlying implementation. If I am wrong, we can always add these methods back.
Fixes #829