Skip to content

feat(transport): add typed HTTP request interface in _requests_base.py (#1508) #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(transport): add typed HTTP request interface in _requests_base.py (#1508) #1714

wants to merge 1 commit into from

Conversation

cureprotocols
Copy link

This PR continues the effort from #1508 by introducing full type annotations to google/auth/transport/_requests_base.py.

✔️ Highlights:

  • Defines a typed Request interface using abc.ABC with clear method contracts.
  • Includes docstrings and a usage example to support onboarding and maintainability.
  • Ensures full compatibility with Mypy under --strict.

✅ Verified clean:

mypy --strict google/auth/transport/_requests_base.py

@cureprotocols cureprotocols requested review from a team as code owners April 3, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cureprotocols