Skip to content

feat(transport): add typed HTTP request interface in _requests_base.py #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cureprotocols
Copy link

This PR continues the effort from #1508 by introducing full type annotations to google/auth/transport/_requests_base.py.

✔️ Highlights:

  • Defines a typed Request interface with a clear abstract contract for HTTP transport implementations.
  • Includes docstrings and usage example for clarity and onboarding.
  • Ensures strict Mypy compatibility under --strict mode.

✅ Clean run: mypy --strict google/auth/transport/_requests_base.py

Happy to refine if needed!

@cureprotocols cureprotocols requested review from a team as code owners April 3, 2025 00:42
Copy link

google-cla bot commented Apr 3, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cureprotocols
Copy link
Author

I signed it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant