Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add type annotations to exceptions module for Mypy strict mode (#1508) #1710

Closed
wants to merge 1 commit into from

Conversation

cureprotocols
Copy link

This PR contributes to issue #1508 by adding full type annotations to google/auth/exceptions.py.

All functions and properties now comply with Mypy's --strict mode.

✔️ Highlights:

  • Added explicit return types for all functions and properties.
  • Replaced keyword-only syntax with **kwargs for Python 3.7 compatibility while preserving clarity and behavior.
  • Maintained full backward compatibility with existing exception usage patterns.
  • Verified clean via: mypy --strict google/auth/exceptions.py.

This is part of the ongoing effort to enhance strict typing across the library.
Happy to refine or expand this PR further as needed!

@cureprotocols cureprotocols requested review from a team as code owners April 2, 2025 23:47
Copy link

google-cla bot commented Apr 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cureprotocols
Copy link
Author

I signed it!

@cureprotocols cureprotocols requested a review from a team as a code owner April 4, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant