fix: don't allow LoadPath to be set via config file
#1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1252 +/- ##
==========================================
- Coverage 68.31% 68.29% -0.02%
==========================================
Files 175 175
Lines 16764 16764
==========================================
- Hits 11452 11449 -3
- Misses 4680 4682 +2
- Partials 632 633 +1 ☔ View full report in Codecov by Sentry. |
cuixq
approved these changes
Sep 16, 2024
cuixq
reviewed
Sep 16, 2024
hogo6002
approved these changes
Sep 17, 2024
G-Rath
force-pushed
the
config/fix-load-path
branch
from
3d0a009
to
96e3b10
Compare
another-rex
approved these changes
Sep 18, 2024
G-Rath
force-pushed
the
config/fix-load-path
branch
2 times, most recently
from
13b71d3
to
b0fbd6a
Compare
G-Rath
force-pushed
the
config/fix-load-path
branch
from
b0fbd6a
to
f88f82e
Compare
another-rex
pushed a commit
that referenced
this pull request
Sep 24, 2024
This behaviour changed as a result of both #1252 (which makes `LoadPath` no longer a recognized config key) and #1249 (which causes the scanner to error when a config has an unknown key), but they didn't directly conflict with each other so got landed on `main` without this being picked up (fwiw I'm not worried about this being a reoccurring thing that's worth guarding or preventing somehow as its usually pretty rare 🤷)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pseudo bug I introduced way back in #190 - it doesn't actually happen as our implementation always explicitly sets the property after we've successfully parsed the file into the struct, but it is possible for refactors like #1248 to reveal this and ultimately we don't want this behaviour so we might as well fix it.