Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't fail if codecov errors when uploading #1061

Closed
wants to merge 1 commit into from

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Jun 21, 2024

Codecov has been just too flakey to have as a requirement for landing changes, so for the time being we're going to ignore if uploading fails

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@0bb73a6). Learn more about missing BASE report.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1061   +/-   ##
=======================================
  Coverage        ?   65.84%           
=======================================
  Files           ?      150           
  Lines           ?     9715           
  Branches        ?        0           
=======================================
  Hits            ?     6397           
  Misses          ?     2852           
  Partials        ?      466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@G-Rath
Copy link
Collaborator Author

G-Rath commented Jun 21, 2024

It looks like the underlying issues might have been resolved in the last couple of hours via codecov/codecov-action#1487 (comment), so I'm going to optimistically close this for now

@G-Rath G-Rath closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants