Fix extract_ir.py for macos. #260
Conversation
| @@ -371,4 +380,5 @@ def main(argv): | |||
|
|
|||
|
|
|||
| if __name__ == '__main__': | |||
| multiprocessing.set_start_method('fork') | |||
There was a problem hiding this comment.
oh, meant to include this in the pull request description. it's because of this
abseil/abseil-py#170
basically, the default method of multiprocessing on macos is spawn instead of fork, which means the flags don't get passed around correctly. The flags are accessed within the spawned processes, so without this line macos will use default flag values for anything inside the subprocess.
compiler_opt/tools/extract_ir.py
Outdated
| 'Name of the section name passed to llvm-objcopy. For linux systems, the ' | ||
| 'default .llvmcmd is correct. On macos, one should use __LLVM,__cmdline' |
There was a problem hiding this comment.
Technically this is not about the OS but about the file format (for example, you might be running training on macOS but using binaries compiled for Linux), so I think it's more accurate to say "ELF" and "Mach-O" rather than "Linux" and "macOS" respectively.
There was a problem hiding this comment.
fixed - thanks!
For whatever reason, the section names for .llvmcmd and .llvmbc are different on macos. One problem is that macos uses macho object files instead of elf, so in addition to the section names there are segment names that need to be specified. The other problem is that regardless of the segments, the section names are different. This patch makes the segment name configurable by a flag, and gives sensible defaults for linux + documentation for macos.
jacob-hegna
force-pushed
the
extractir_macos
branch
from
3b5c7e8 to
6f0d7a5
Compare
For whatever reason, the section names for .llvmcmd and .llvmbc are different on macos. One problem is that macos uses macho object files instead of elf, so in addition to the section names there are segment names that need to be specified. The other problem is that regardless of the segments, the section names are different. This patch makes the segment name configurable by a flag, and gives sensible defaults for linux + documentation for macos.