Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[runsc] Print file name when cannot load state file #11461

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

[runsc] Print file name when cannot load state file

When runsc does not work, there are messages like

loading container: file does not exist
...
loading sandbox: file does not exist

The problem here is, there is no indication of file path, making it harder to debug.

I don't have access to environment where these errors appear, so I cannot repro. Better diagnostics would help.

There's a comment in code suggesting that error code is important, so we cannot modify error IIUC

// Preserve error so that callers can distinguish 'not found' errors.

so my suggestion is to log the file name.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11457 from stepancheg:state-file f0ac6d5

@copybara-service copybara-service bot added the exported Issue was exported automatically label Feb 10, 2025
@copybara-service copybara-service bot force-pushed the test/cl725255102 branch 5 times, most recently from ffd7e24 to 6b158ce Compare February 12, 2025 19:49
@copybara-service copybara-service bot closed this Feb 12, 2025
@copybara-service copybara-service bot deleted the test/cl725255102 branch February 12, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exported Issue was exported automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants