-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional allow attributes & tags #259
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
At the moment this package is aimed at aligning with github gfm sanitization rules: Arguably, these have changed, I don't think github uses that code anymore. But I'm hesitant to just add features. If there is a lot of community members that would rather have an HTML sanitation package with more advanced features I'm inclined to suggest that you write such a package, publish and maintain it yourself. Feel free to fork this package and give it a new better name, ideally collaborate with others. Honestly, I'd be more than happy for On topic of this PR, I might get around to doing a review, but again, I'm hesitant to accept more features. Maybe, if it turns out we need them elsewhere too. |
Yes, Maybe we should develop a separate package that allows people to use the advanced features of sanitize_html. If I have time, I will do it. Stay tuned in this PR. |
No description provided.