Trim whitespace around secret references (#304)

Fixes #303
google-github-actions · Oct 25, 2024 · e51ee21 · e51ee21
1 parent ca38f18
commit e51ee21
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/reference.ts b/src/reference.ts
@@ -43,8 +43,15 @@ export class Reference {
 
     this.output = sParts[0].trim();
 
-    const ref = sParts.slice(1).join(':');
-    const refParts = ref.split('/');
+    // Trim each piece and remove empty entries
+    const refParts =
+      sParts
+        ?.slice(1)
+        ?.at(0)
+        ?.split('/')
+        ?.map((p) => (p || '').trim())
+        ?.filter((p) => p !== '') || [];
+
     switch (refParts.length) {
       // projects/<p>/locations/<l>/secrets/<s>/versions/<v>
       case 8: {

diff --git a/tests/reference.test.ts b/tests/reference.test.ts
@@ -41,6 +41,14 @@ test('Reference', { concurrency: true }, async (suite) => {
       input: 'out:my-project/my-secret',
       expected: 'projects/my-project/secrets/my-secret/versions/latest',
     },
+    {
+      input: 'out: my-project/my-secret',
+      expected: 'projects/my-project/secrets/my-secret/versions/latest',
+    },
+    {
+      input: 'out : projects/ my-project/   secrets/	my-secret',
+      expected: 'projects/my-project/secrets/my-secret/versions/latest',
+    },
     {
       input: '',
       error: 'TypeError',