-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Updated Providing_base_cases.ipynb to use google-genai #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -6,7 +6,7 @@ | |||
"id": "gy3KpnNx_Jl4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #2. You are an assistant that helps tourists around the world to plan their vacation. Your responsibilities are:
Can you add some indentation to improve readability? Like
instructions = """ You are an assistant that helps tourists around the world to plan their vacation. Your responsibilities are: 1. Helping book the hotel. 2. Recommending restaurants. 3. Warning about potential dangers. If other request is asked return "I cannot help with this request." """
Reply via ReviewNB
@@ -6,7 +6,7 @@ | |||
"id": "gy3KpnNx_Jl4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #1. MODEL_ID="gemini-2.0-flash" # @param ["gemini-2.0-flash-lite","gemini-2.0-flash","gemini-2.5-pro-exp-03-25"] {"allow-input":true, isTemplate: true}
We don't need to define the model all the time. I think once at the beginning of the notebook is enough.
Reply via ReviewNB
@@ -6,7 +6,7 @@ | |||
"id": "gy3KpnNx_Jl4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #1. print("ON TOPIC:", on_topic_response.text)
Can you use display(Markdown())
to improve the rendering of the markdown?
Reply via ReviewNB
@@ -6,7 +6,7 @@ | |||
"id": "gy3KpnNx_Jl4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -6,7 +6,7 @@ | |||
"id": "gy3KpnNx_Jl4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #1. print('''## Specified genre:
Can you use display(Markdown())
to improve the rendering of the markdown? I also don't think the line breaks are needed.
Reply via ReviewNB
Thanks for the submission @Shi-pra-19! It's the first one if I'm not mistaken 🥳 I just added a couple of minor comments to make the notebook easier to understand. Can you also check the format failures. It is likely because you haven't run the formatting script. Thanks again! |
Updated module google-generativeai to use google-genai
Refactored imports