Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chrome pinch #1

Merged
merged 1 commit into from
Nov 16, 2018
Merged

fix chrome pinch #1

merged 1 commit into from
Nov 16, 2018

Conversation

wmoai
Copy link

@wmoai wmoai commented Oct 23, 2018

https://github.com/goodpatch/prott-webapp/issues/2548

pointer eventがうまく動いていないので無効にする

@wmoai wmoai self-assigned this Oct 23, 2018
@wmoai
Copy link
Author

wmoai commented Nov 2, 2018

ここでこの問題について議論されています
hammerjs#1084

@wmoai wmoai requested a review from nsyee November 2, 2018 09:36
@wmoai
Copy link
Author

wmoai commented Nov 2, 2018

@nsyee ピンチジェスチャできない問題に関連してhammerjsに怪しい修正を入れたのでレビューお願いします!

Copy link

@nsyee nsyee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wmoai LGTM!! 寿司ゆき:thanks

@wmoai wmoai merged commit ee3993b into master Nov 16, 2018
@wmoai wmoai deleted the fix-chrome-pinch branch November 16, 2018 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants