Remove ADDITIONAL_VERIFICATION_COST setting default from base and tes… #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwrzesien
requested review from
cameel,
Jakub89,
bartoszbetka,
kbeker,
pawelkisielewicz and
dybi
dybi
reviewed
Nov 27, 2018
| @@ -310,9 +310,6 @@ | |||
| # completing verification. | |||
| ADDITIONAL_VERIFICATION_TIME_MULTIPLIER = 2.0 | |||
|
|
|||
| # A global constant defining the cost of additional verification if provider requested it. | |||
There was a problem hiding this comment.
shouldn't it be left here? At least in commented out form?
pawelkisielewicz
approved these changes
Nov 27, 2018
dybi
approved these changes
Nov 28, 2018
…ting and add it to development
rwrzesien
force-pushed
the
feature-allow-setting-verification-cost-to-zero
branch
from
8f01e71 to
c8cdf73
Compare
rwrzesien
deleted the
feature-allow-setting-verification-cost-to-zero
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ting and add it to development
Resolves #939
After examining the issue it seems that is just enough to modify the settings, the implementation already handles this issue correctly, and tests cover that case.