Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test that no word is marked as both correct and incorrect #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dzhu
Copy link

@dzhu dzhu commented May 9, 2020

The test ensures that users can't get an error, follow the suggested fix, and still get an error. Also fix up the word list to make the test pass (and fix misspellings, of course).

dzhu added 2 commits May 9, 2020 16:02
Apart from being linguistically incorrect, these lines could previously
have caused someone to get an error, follow the suggested fix, and still
get an error.
The test ensures that users can't get an error, follow the suggested
fix, and still get an error. Also fix up the word list to make the test
pass (and fix misspellings, of course).
@dzhu dzhu changed the title correct all target words that should be "definitely" add a test that no word is marked as both correct and incorrect May 10, 2020
@jirfag
Copy link
Member

jirfag commented May 17, 2020

thank you very much,
but let's change source data generator instead, please.

@dzhu
Copy link
Author

dzhu commented May 17, 2020

Oops! I saw the warning that the file is auto-generated, but I couldn't find any link to the generator, so I thought it was outdated or something. I will make the word list changes in the other repository. Should the test still be here, though?

@jirfag
Copy link
Member

jirfag commented May 18, 2020

thank you,
yes, I think test here will be useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants