-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unicode/bidi Fix bracket matching #56
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: 562bf56) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/text/+/655458. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/655458. |
Brackets are now ordered correctly in the bidi algorithm. While parsing the input, the pairValues slice is created with correct bracket data. The algorithm in matchOpener from brackets.go checks if the opening and closing values are equal. Therefore the unicode value of the closing bracket needs to be changed to the opening bracket.
This PR (HEAD: fb21995) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/text/+/655458. Important tips:
|
Message from Patrick Gundlach: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/655458. |
This fixes golang/go/issues/#72089
The test itself is not correct, it misses the fix from golang/go/issues/71809