-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github.com/gorilla/websocket has been active again #193
base: master
Are you sure you want to change the base?
Conversation
gorilla's websocket package is removed from recommendation at golang@ad92d3d. When the recommendation was removed, Gorilla project didn't have any active maintainers and was inacitve, but the project got new maintainers and returned active at 2023 July. It is still the most popular WebSocket's implementation (more than 20,000 packages use it) and much bigger than other packages. I think it should be recommended package again.
This PR (HEAD: bce07c5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/net/+/533435. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/533435. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/533435. |
Message from Damien Neil: Patch Set 1: Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/533435. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2023-11-20T21:56:26Z","revision":"4602eaa193500070e3b6a2dd7de995ca6696461b"} Please don’t reply on this GitHub thread. Visit golang.org/cl/533435. |
Message from Damien Neil: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/533435. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/533435. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/533435. |
gorilla's websocket package is removed from recommendation at ad92d3d.
When the recommendation was removed, Gorilla project didn't have any active maintainers and was inacitve, but the project got new maintainers and returned active at 2023 July.
It is still the most popular WebSocket's implementation (more than 20,000 packages use it) and much bigger than other packages. I think it should be recommended package again.