Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ports option #79

Merged
merged 10 commits into from
Jan 28, 2025
Merged

Add ports option #79

merged 10 commits into from
Jan 28, 2025

Conversation

andig
Copy link
Contributor

@andig andig commented Jan 26, 2025

Fix #78

@damdo
Copy link
Contributor

damdo commented Jan 26, 2025

How about actually calling the option flag netdev since that's what it actually is?
Otherwise if we really want to call it ports I think we should restrict and sanitize it to only actually be port mappings (ala docker).

After all the gok vm command wraps a qemu vm, so I'm up for exposing some of qemu functionality if required.

@damdo
Copy link
Contributor

damdo commented Jan 26, 2025

But let's see what @stapelberg thinks.

@stapelberg
Copy link
Contributor

How about actually calling the option flag netdev since that's what it actually is?

Yeah, I think that’s a good suggestion (as long as the example in the flag help output is good).

That way, users can use the full power of the netdev qemu option.

@andig andig marked this pull request as ready for review January 27, 2025 08:25
internal/gok/vmrun.go Outdated Show resolved Hide resolved
internal/gok/vmrun.go Outdated Show resolved Hide resolved
@stapelberg stapelberg merged commit 6316042 into gokrazy:main Jan 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gok vm: add custom ports
3 participants