-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable edit default quota button when not editable #20810
base: main
Are you sure you want to change the base?
Conversation
d36013a
to
d7d39b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20810 +/- ##
===========================================
+ Coverage 45.36% 66.22% +20.85%
===========================================
Files 244 1045 +801
Lines 13333 113501 +100168
Branches 2719 2845 +126
===========================================
+ Hits 6049 75167 +69118
- Misses 6983 34227 +27244
- Partials 301 4107 +3806
Flags with carried forward coverage won't be shown. Click here to find out more. |
The |
If |
d7d39b8
to
4aa1ffa
Compare
I've rebased the change on the current main branch. I still think it's a straight-forward fix for a very confusing issue in the UI. It brings the same solution as applied for many settings in the tab "Administration -> Configuration" to the attribute "default quota space per project". |
This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days. |
Signed-off-by: Henning Poettker <[email protected]>
4aa1ffa
to
0114ca2
Compare
I've rebased the change on the current main branch. |
Comprehensive summary of your change
The PR disables the edit button for the default quota space per project when the configuration property
storage_per_project
is set to not editable, which is e.g. the case when the environment variableCONFIG_OVERRIDE_JSON
is set for the core.Issue being fixed
Currently the edit button is always enabled and the modal dialog for changing the default quota space always opens. When however the property
storage_per_project
is not editable, a submission in the modal dialog will lead to the error messageSave abort because nothing changed
being displayed, and the modal dialog can only be exited by clicking the cancel button.Please indicate you've done the following: