-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📒 doc: Add ctx.Drop() to whats_new.md #3284
Conversation
Thanks for opening this pull request! 🎉 Please check out our contributing guidelines. If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
WalkthroughThe pull request introduces significant updates to the Fiber framework's version 3, focusing on method signature changes, routing enhancements, and context handling mechanisms. The changes primarily involve updating router methods to require a single handler with optional middleware, removing deprecated methods, introducing new customization methods, and improving context interface flexibility. The modifications aim to provide developers with more clarity, performance, and extensibility in their web application development. Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/whats_new.md (1)
345-345
: LGTM! Consider enhancing the documentation with an example.The documentation for the
Drop()
method is clear and well-placed. The description effectively explains its purpose and use cases.Consider adding a code example to demonstrate its usage, similar to other methods in the documentation. Here's a suggested example to add:
app.Get("/sensitive", func(c fiber.Ctx) error { if !isAuthorized(c) { // Silently terminate the connection without response return c.Drop() } return c.SendString("Authorized access") })
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! If you need help or want to chat with us, join us on Discord https://gofiber.io/discord |
Description
Added missing Drop() documentation to whats_new.md
Fixes #3282
Changes introduced
Type of change
Checklist
Before you submit your pull request, please make sure you meet these requirements:
/docs/
directory for Fiber's documentation.