Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 [Maintenance]: Add ctx.Drop() to whats_new.md #3282

Closed
3 tasks done
grivera64 opened this issue Jan 17, 2025 · 3 comments · Fixed by #3284 or #3285
Closed
3 tasks done

🧹 [Maintenance]: Add ctx.Drop() to whats_new.md #3282

grivera64 opened this issue Jan 17, 2025 · 3 comments · Fixed by #3284 or #3285
Labels
👍 Accepting PR 🧹 Updates v3
Milestone
v3

Comments

@grivera64
Copy link
Member

Maintenance Task Description

Documentation for c.Drop() is missing from whats_new.md.

This issue proposes to add the missing documentation to the whats_new.md.

Impact on the Project

This will ensure users know about the new c.Drop() as a new feature when reading the whats_new.md file on release.

Additional Context (optional)

PR #3257 introduced this feature, and included the docs in ctx.md.

Checklist:

  • I have confirmed that this maintenance task is currently not being addressed.
  • I understand that this task will be evaluated by the maintainers and prioritized accordingly.
  • I am available to provide further information if needed.
@ReneWerner87 ReneWerner87 added this to the v3 milestone Jan 18, 2025
@ReneWerner87 ReneWerner87 added this to v3 Jan 18, 2025
@aliziyacevik aliziyacevik mentioned this issue Jan 18, 2025
Merged
7 tasks
@github-project-automation github-project-automation bot moved this to Done in v3 Jan 18, 2025
@grivera64
Copy link
Member Author

Should we also add an example under ctx.End() for ctx.Drop() in whats_new.md as well?

@grivera64 grivera64 reopened this Jan 19, 2025
@gaby
Copy link
Member

gaby commented Jan 19, 2025

Should we also add an example under ctx.End() for ctx.Drop() in whats_new.md as well?

Yes! 😂

@grivera64 grivera64 mentioned this issue Jan 19, 2025
Merged
16 tasks
@grivera64
Copy link
Member Author

Should we also add an example under ctx.End() for ctx.Drop() in whats_new.md as well?

Yes! 😂

🤣 Made a PR to add it too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👍 Accepting PR 🧹 Updates v3
Projects
v3
Status: Done
Milestone
v3
3 participants
@gaby @ReneWerner87 @grivera64